Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep a reference to the Frame when returning position/velocities view #40

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

Luthaf
Copy link
Member

@Luthaf Luthaf commented Jun 22, 2020

This should prevent the GC from removing the frame and the corresponding memory too early.

This fixes #37 for me, over 500 include.

This should prevent the GC from removing the frame and the corresponding memory too
early
@Luthaf
Copy link
Member Author

Luthaf commented Jun 22, 2020

@amlimaye let me know if that also works for you!

@amlimaye
Copy link

Works! Thanks for the fix.

@Luthaf Luthaf merged commit 91580d8 into master Jun 24, 2020
@Luthaf Luthaf deleted the fix-segfault branch June 24, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-deterministic segmentation faults when reading LAMMPS dump files using Julia bindings
2 participants