-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding organization_feature_access table & functionality #796
Open
carere
wants to merge
8
commits into
main
Choose a base branch
from
feature/add-organization-feature-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
I left you some comments in the PR body.
The two main points I have to add here:
- at a high level, the idea is that the front no longer stores the license key, instead calls this new endpoint on the backend that will: read feature accesses, merge them with the features available on the license (which the backend validates with our license server), and return the merged set of features to the frontend
- as a result, while the API return DTO should contain all the relevant features, we only need to specifically store in the DB at the org level, those that we want to set at the org level. That is: sanctions, test run (as of today). So you can simplify by reducing the nb of features we store.
- last point, for orgs we create internally, the API should accept a list of features to add when the org is created, so we should add this input in the org creation API DTO, and pass it over to the org creation repository (end customers who self-host are not expected to use this)
repositories/migrations/20250108102844_add_organization_feature_access_table.sql
Outdated
Show resolved
Hide resolved
repositories/migrations/20250108102844_add_organization_feature_access_table.sql
Outdated
Show resolved
Hide resolved
carere
force-pushed
the
feature/add-organization-feature-access
branch
from
January 9, 2025 14:37
feee8a9
to
bb88dfd
Compare
Pascal-Delange
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.