fix: silent error during batch ingestion #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascal-Delange
commented
Jan 6, 2025
| @@ -387,7 +387,7 @@ func (usecase *IngestionUseCase) processUploadLog(ctx context.Context, uploadLog | |||
| out := usecase.readFileIngestObjects(ctx, file.FileName, file.ReadCloser) | |||
| if out.err != nil { | |||
| setToFailed(out.numRowsIngested) | |||
| return err | |||
| return out.err | |||
There was a problem hiding this comment.
The main point of the PR is here. The rest is mainly cleaning up potentially duplicate error handling
Pascal-Delange
commented
Jan 6, 2025
| @@ -13,14 +12,6 @@ func LogAndReportSentryError(ctx context.Context, err error) { | |||
| logger := LoggerFromContext(ctx) | |||
| logger.ErrorContext(ctx, fmt.Sprintf("%+v", err)) | |||
|
|
|||
| // Known issue where Cloud Run will sometimes fail to create the unix socket to connect to CloudSQL. | |||
There was a problem hiding this comment.
Shouldn't be so much of an issue any more, this was a pain point when we were starting a cloud run job 3 times per minute, and just hitting the CloudSQL availability SLAs.
Pascal-Delange
force-pushed
the
pascal/mar-689-db-connection-errors-do-not-pass-silently-in-batch-ingestion
branch
from
394eccb to
98dfabd
Compare
Pascal-Delange
deleted the
pascal/mar-689-db-connection-errors-do-not-pass-silently-in-batch-ingestion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.