Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More isolation per aws-checker instance for testing #11

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Oct 8, 2024

Refactors the checker for more isolation between instances, so that you can instantiate multiple aws-checker instances in test without inferring and breaking each other.

Copy link
Contributor

@cw-atkhry cw-atkhry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cw-atkhry cw-atkhry merged commit 3df3029 into chatwork:main Oct 11, 2024
1 check passed
@mumoshu mumoshu mentioned this pull request Oct 15, 2024
@mumoshu mumoshu deleted the instance-isolation-for-test branch October 15, 2024 02:22
@mumoshu mumoshu mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants