Bump to Elixir v1.16.0 and OTP 26 #1
Conversation
| @@ -5,7 +5,7 @@ defmodule ExMarcel.MixProject do | |||
| [ | |||
| app: :ex_marcel, | |||
| version: "0.1.0", | |||
| elixir: "~> 1.12", | |||
| elixir: "~> 1.14", | |||
There was a problem hiding this comment.
what will happen with apps running 1.12?
There was a problem hiding this comment.
Apps running Elixir below 1.14 probably won't work. That's should be fine, because only the latest three Elixir releases along with the latest 3 OTP releases should be supported.
There was a problem hiding this comment.
uhm could that break many applications? what would be the implicancies to relax the version? I guess it should work anyway...
There was a problem hiding this comment.
Tested it in an app with Elixir v1.12 OTP 24. It seems to be working. But there's a compilation warning
warning: the dependency :ex_marcel requires Elixir "~> 1.14" but you are running on v1.12.3.
Disclaimer - this is just my guess. I'm not 100% sure about this.
It may not be the case of this library, but Elixir Kernel and/or Erlang functions may differ. Relaxing the version may get someone using this library with older Elixir/OTP version and causing errors and/or crashes.
|
thanks for the contribution, just added one question |
|
@michelson for elixir libraries anyone running older than 3 versions should be left behind. For I would say supporting back to 1.14 should be minimum and anyone on 1.12 needs to update as that does not compile with latest OTP at all and has severe security vulnerabilities. |
|
@michelson any news if we can get this bump to happen? The string slice warning is now appearing all over my tests. |
|
@michelson any updates? |
Also formatted the code, resolved
String.slice/2warning appearing with Elixir v1.16-otp-26 and updated github workflows ci config file