Fix/slice overflow #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberthirst
force-pushed
the
fix/slice-overflow
branch
from
506383f to
a78ba17
Compare
| # overflow: | ||
| # valid inputs satisfy: `assert start+length <= src_len && start+length > start` | ||
| def _make_slice_bounds_check(start, length, src_len): | ||
| return [ |
There was a problem hiding this comment.
i'd like to see sanity check assertions that start, length and src_len all have .is_complex_ir is False
charles-cooper
approved these changes
Mar 17, 2024
charles-cooper
merged commit 00435d8
into
charles-cooper:fix/slice-overflow
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
buildIRHow I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture