feat: event exports #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
approved these changes
Feb 24, 2024
| @@ -167,7 +167,7 @@ pass_stmt: _PASS | |||
| break_stmt: _BREAK | |||
| continue_stmt: _CONTINUE | |||
|
|
|||
| log_stmt: _LOG NAME "(" [arguments] ")" | |||
| log_stmt: _LOG (NAME | variable_access) "(" [arguments] ")" | |||
There was a problem hiding this comment.
no, previously only log Event() was allowed
| @@ -728,6 +728,10 @@ def validate(self): | |||
| class Log(Stmt): | |||
| __slots__ = ("value",) | |||
|
|
|||
| def validate(self): | |||
| if not isinstance(self.value, Call): | |||
There was a problem hiding this comment.
yea, it's in the structure exception tests somewhere
There was a problem hiding this comment.
hmm, i thought i saw it before but maybe i hallucinated, so i added one here 9ed427f
add `exports:` declaration to the language. this allows users to directly export functions marked `@external` from libraries instead of writing `@external` wrapper functions (and consequently, for library authors to define the external interface for their modules). important refactors: - remove expanded getters from module AST, change them to annotation on public VariablDecls. - redo order of node visitation in ModuleAnalyzer - refactor `InterfaceT.validate_implements()` to handle exported functions - add `exposed_functions` property to `ModuleT` which reflects the runtime functions exposed in the selector table - refactor IR generation to use new reachability analysis misc: - remove Module.add_to_body, Module.remove_from_body as they are dead now - move VariableDecl validation to vyper/ast/nodes.py - improve call-site annotations for error messages - improve annotations for exceptions which reference a previously- declared node.
- improve call graph analysis - called_functions and reachable_internal_functions start out as None - move analyze_call_graph into standalone function instead of method - tinker with _add_exposed_function to ensure we have all exposed functions by the time we get to ImplementsDecl
rely on analysis, not declared events
change the event member names in the builtin interfaces
rename a test file
This reverts commit 0747a5c.
charles-cooper
force-pushed
the
feat/event-exports
branch
from
b2ba9e6 to
dde7d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
clean diff
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture