Change PaymentModel#date type to datetime_utc #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speric
force-pushed
the
payment-datetime-utc
branch
from
cf5b177 to
f58dba1
Compare
By changing the type of `PaymentModel#date`, `Invoice#date` to `datetime_utc`, we can pass timestamps with UTC offsets to appropriate Xero API endpoints, and let Xero parse the dates in the proper timezone for the Organisation in context.
speric
force-pushed
the
payment-datetime-utc
branch
from
f58dba1 to
c383690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the type of
PaymentModel#datetodatetime_utc, we can pass timestamps with UTC offsets to Xero's payments API endpoint, and let Xero parse the dates in the proper timezone for the Organisation in context.