Skip to content

Commit

Permalink
add network_id and psp_transaction_id to TransactionDetail (#23)
Browse files Browse the repository at this point in the history
* add network_id and psp_transaction_id to TransactionDetail

* add subscription_id to Charge

* Protobuf Updates
add subscription_id to Charge
remove subscription_id from Transaction
generate code
  • Loading branch information
fobilow authored Feb 10, 2023
1 parent 6090d76 commit 1fffb68
Show file tree
Hide file tree
Showing 8 changed files with 375 additions and 247 deletions.
1 change: 1 addition & 0 deletions chargehive/chtype/charge.proto
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ message Charge {
chtype.PaymentMethodType preferred_method_type = 17;
string billing_profile_id = 18;
repeated InitialTransactionData initial_transaction = 19;
string subscription_id = 20;
}

message ChargeItem {
Expand Down
2 changes: 2 additions & 0 deletions chargehive/chtype/transaction.proto
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ message TransactionDetail {
string connector_library = 19;
string connector_id = 20;
bool primary = 21;
string network_id = 22; // Network ID returned by the PSP
string psp_transaction_id = 23; // Transaction ID returned by the PSP to replace transaction_id which is ambiguous
}

message VerifyRequestData {
Expand Down
271 changes: 140 additions & 131 deletions golang/chargehive/chtype/charge.pb.go

Large diffs are not rendered by default.

244 changes: 131 additions & 113 deletions golang/chargehive/chtype/transaction.pb.go

Large diffs are not rendered by default.

27 changes: 27 additions & 0 deletions php/ChargeHive/Chtype/Charge.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified php/ChargeHive/Chtype/Metadata/Charge.php
Binary file not shown.
9 changes: 6 additions & 3 deletions php/ChargeHive/Chtype/Metadata/Transaction.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 68 additions & 0 deletions php/ChargeHive/Chtype/TransactionDetail.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1fffb68

Please sign in to comment.