Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confluence token authentication #824

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Confluence token authentication #824

merged 1 commit into from
Oct 13, 2023

Conversation

zhifeiyue
Copy link
Contributor

Support token authentication for Confluence backend.

For Confluence Data Center or server editions, just use the personal access token:
perceval confluence 'http://[YOUR_CONFLUENCE_SITE]/' -t [PERSONAL_ACCESS_TOKEN]

For Confluence cloud:
perceval confluence -u '[email protected]' -t [API_TOKEN] 'https://[YOUR_SITE].atlassian.net/wiki'

sduenas
sduenas requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your PR. Would you mind to address my comments?

perceval/backends/core/confluence.py Show resolved Hide resolved
perceval/backends/core/confluence.py Show resolved Hide resolved
perceval/backends/core/confluence.py Outdated Show resolved Hide resolved
perceval/backends/core/confluence.py Outdated Show resolved Hide resolved
perceval/backends/core/confluence.py Outdated Show resolved Hide resolved
releases/unreleased/add-token-auth-for-confluence.yml Outdated Show resolved Hide resolved
releases/unreleased/add-token-auth-for-confluence.yml Outdated Show resolved Hide resolved
@zhifeiyue zhifeiyue requested a review from sduenas October 11, 2023 06:17
sduenas
sduenas approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but, before we merge it, would you mind to squash the commits into a single one and sign it?

@zhifeiyue
Copy link
Contributor Author

It looks good to me but, before we merge it, would you mind to squash the commits into a single one and sign it?

ok, I just finished it.

@sduenas
Copy link
Member

sduenas commented Oct 11, 2023

@zhifeiyue the tests are complaining because line 67 is too long.

@zhifeiyue @sduenas
Confluence token authentication
2da9971 
Signed-off-by: zhifeiyue <[email protected]>
Co-Authored-By: Santiago Dueñas <[email protected]>
@coveralls
Copy link

coveralls commented Oct 11, 2023 •
edited
Loading

Coverage Status

coverage: 92.624% (-0.05%) from 92.676% when pulling 2da9971 on zhifeiyue:master into fd32648 on chaoss:master.

sduenas
sduenas approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit 33607a3 into chaoss:master Oct 13, 2023
6 checks passed
@sduenas
Copy link
Member

sduenas commented Oct 13, 2023

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduenas sduenas sduenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhifeiyue @sduenas @coveralls