Update log message when sending account creation email #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the message to make it clear that we send both a user and admins messages
samuel-duhaime
approved these changes
Jan 21, 2025
tahini
requested changes
Jan 21, 2025
| @@ -154,7 +154,7 @@ export const sendConfirmationEmail = async ( | |||
| emails.forEach(async (email) => { | |||
| await sendEmail(email, { userConfirmationUrl: { url: options.confirmUrl }, usermail: user.email }); | |||
| }); | |||
| console.log('Email sent for account confirmation'); | |||
| console.log('Emails (admins and user) sent for account confirmation'); | |||
There was a problem hiding this comment.
En fait, on ne sait pas si c'est admin and user, ça dépend de la config, ça peut être juste le user si on a confirmByUser. Donc admin and/or user serait plus juste.
There was a problem hiding this comment.
Bon, encore mieux, je devrais checker le length de emails, et dire XX Emails (admins and/or user) sent for account confirmation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the message to make it clear that we send both a user and admins messages