paths: update layers when TransitPathEdit component is mounted #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes chairemobilite#1178 The upgrade to React 19 seemingly changed the handling of events in such a way that the path selection event is now handled before the `TransitPathEdit` component is mounted, while it was handled after in the React 16 version. So we call the `updateLayers` method at mount to display the selected path.
|
Kind of curious, would other things be impacted by something like that? |
I'd say probably, but there's no way to find out until our users report bugs. But nothing critic that could lead to bad data or calculation errors (at least nothing worse than our current "bad data path" where schedules are not updated when paths are updated) |
greenscientist
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1178
The upgrade to React 19 seemingly changed the handling of events in such a way that the path selection event is now handled before the
TransitPathEditcomponent is mounted, while it was handled after in the React 16 version. So we call theupdateLayersmethod at mount to display the selected path.