Upgrade lint warnings to errors.

Configures lint so that every warning (expect for no-explicit-any, no-var-requires, and no-require-imports) will now be considered errors.
Also removes the remaining  warnings missed by the previous PRs.

configs/base.eslintrc.json

@@ -9,32 +9,32 @@
         "@typescript-eslint/no-explicit-any": "warn",
         "@typescript-eslint/no-require-imports": "warn",
         "arrow-parens": ["error", "always"],
-        "brace-style": ["warn", "1tbs", { "allowSingleLine": true }],
-        "constructor-super": "warn",
+        "brace-style": ["error", "1tbs", { "allowSingleLine": true }],
+        "constructor-super": "error",
         "n/no-missing-require": ["error", {
             "tryExtensions": [".js", ".json", ".node", ".ts"]
         }],
-        "indent": ["warn", 4, {"VariableDeclarator": 0}],
+        "indent": ["error", 4, {"VariableDeclarator": 0}],
         "linebreak-style": ["error", "unix"],
-        "no-dupe-keys": "warn",
-        "no-empty": "warn",
+        "no-dupe-keys": "error",
+        "no-empty": "error",
         "no-empty-function": "error",
-        "no-unexpected-multiline": "warn",
-        "no-constant-condition": "warn",
-        "no-this-before-super": "warn",
-        "no-import-assign": "warn",
-        "no-irregular-whitespace": "warn",
+        "no-unexpected-multiline": "error",
+        "no-constant-condition": "error",
+        "no-this-before-super": "error",
+        "no-import-assign": "error",
+        "no-irregular-whitespace": "error",
         "no-trailing-spaces": "error",
-        "no-const-assign": "warn",
-        "no-mixed-spaces-and-tabs": "warn",
-        "no-useless-escape": "warn",
-        "no-cond-assign": "warn",
-        "no-dupe-else-if": "warn",
+        "no-const-assign": "error",
+        "no-mixed-spaces-and-tabs": "error",
+        "no-useless-escape": "error",
+        "no-cond-assign": "error",
+        "no-dupe-else-if": "error",
         "no-unused-vars": "off",
-        "@typescript-eslint/no-unused-vars": ["warn", { "vars": "all", "args": "after-used", "argsIgnorePattern": "^_", "ignoreRestSiblings": false }],
-        "object-curly-spacing": ["warn", "always"],
+        "@typescript-eslint/no-unused-vars": ["error", { "vars": "all", "args": "after-used", "argsIgnorePattern": "^_", "ignoreRestSiblings": false }],
+        "object-curly-spacing": ["error", "always"],
         "semi": ["error", "always"],
-        "quotes": ["warn", "single"]
+        "quotes": ["error", "single"]
     }
 }
 

configs/gts.eslintrc.json

@@ -14,7 +14,7 @@
       "eol-last": "error",
       "prefer-arrow-callback": "error",
       "no-trailing-spaces": "error",
-      "quotes": ["warn", "single", { "avoidEscape": true }],
+      "quotes": ["error", "single", { "avoidEscape": true }],
       "no-restricted-properties": [
         "error",
         {
@@ -35,7 +35,7 @@
           "plugin:@typescript-eslint/recommended"
         ],
         "rules": {
-          "@typescript-eslint/ban-ts-comment": "warn",
+          "@typescript-eslint/ban-ts-comment": "error",
           "@typescript-eslint/no-non-null-assertion": "off",
           "@typescript-eslint/no-use-before-define": "off",
           "@typescript-eslint/no-warning-comments": "off",

configs/react.eslintrc.json

@@ -9,10 +9,10 @@
         "node": true
     },
     "rules": {
-        "react/prop-types": "warn",
-        "react/no-string-refs": "warn",
-        "react/no-unescaped-entities": "warn",
-        "react/display-name": "warn"
+        "react/prop-types": "error",
+        "react/no-string-refs": "error",
+        "react/no-unescaped-entities": "error",
+        "react/display-name": "error"
     },
     "parserOptions": {
         "ecmaFeatures": {

packages/chaire-lib-backend/src/config/dotenv.config.ts

@@ -44,4 +44,6 @@ const dotEnvPath = getDotEnvFile();
 if (dotEnvPath !== null) {
     console.log(`Using .env file from ${dotEnvPath}`);
 }
+
+/* eslint-disable-next-line */
 export default require('dotenv').config({ path: dotEnvPath });

packages/chaire-lib-backend/src/config/knexfile.ts

@@ -4,6 +4,8 @@
  * This file is licensed under the MIT License.
  * License text available at https://opensource.org/licenses/MIT
  */
+
+/* eslint-disable-next-line @typescript-eslint/no-require-imports */
 require('./dotenv.config'); // dotenv is required to get the connection strings
 import config from './server.config';
 // TODO Let this data be in the config file instead, but only when the server config is separate from project config to not leak data

packages/chaire-lib-backend/src/utils/json2capnp/Json2CapnpService.ts

@@ -6,6 +6,7 @@
  */
 import url from 'url';
 // TODO replace this fetch-retry library with one compatible with TS
+/* eslint-disable-next-line */
 const fetchRetry = require('@zeit/fetch-retry')(require('node-fetch'));
 
 // Only do 4 retries instead of the default 5, as the retry period increases at

packages/chaire-lib-backend/src/utils/osrm/OSRMMode.ts

@@ -16,6 +16,7 @@ import * as Status from 'chaire-lib-common/lib/utils/Status';
 import { TransitionRouteOptions, TransitionMatchOptions } from 'chaire-lib-common/lib/api/OSRMRouting';
 
 //TODO replace this fetch-retry library with one compatible with TS
+/* eslint-disable-next-line */
 const fetch = require('@zeit/fetch-retry')(require('node-fetch'));
 
 type OSRMServiceTypes = 'route' | 'nearest' | 'table' | 'match' | 'trip' | 'tile';

packages/chaire-lib-backend/src/utils/trRouting/TrRoutingServiceBackend.ts

@@ -6,6 +6,7 @@
  */
 
 //TODO replace this fetch-retry library with one compatible with TS
+/* eslint-disable-next-line */
 const fetch = require('@zeit/fetch-retry')(require('node-fetch'));
 
 import ServerConfig from '../../config/ServerConfig';

packages/chaire-lib-common/src/services/routing/ManualRoutingService.ts

@@ -7,7 +7,6 @@
 import * as RoutingService from './RoutingService';
 import * as turf from '@turf/turf';
 import _cloneDeep from 'lodash/cloneDeep';
-import { TripRoutingQueryAttributes } from './types';
 
 /**
  * This class provides routing services using manual routing. This mode will always return return results

packages/chaire-lib-common/src/services/routing/RoutingService.ts

@@ -6,7 +6,6 @@
  */
 import GeoJSON from 'geojson';
 import { RoutingMode } from '../../config/routingModes';
-import { TripRoutingQueryAttributes } from './types';
 
 // FIXME Make sure these parameters are those that apply to map matching as the name implies
 export interface MapMatchParameters {