Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change simple-web to not use deprecated boost const_buffers_1 #303

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

greenscientist
Copy link
Contributor

No description provided.

@greenscientist
Copy link
Contributor Author

Closes #301

Copy link
Collaborator

@tahini tahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok... and this Iterator is exactly equivalent and the same as previously? There is no other change required anywhere?

@greenscientist
Copy link
Contributor Author

Seems to work...
I've done Claude's suggestion, it's the only changes to make it compile.

I've tested in transition, accessbility map and route calculations works .

Guessing that with this change the right iterator types is picked up. I've sent the changes upstream, wondering if it will be picked as is.

Copy link
Collaborator

@tahini tahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which upstream? can you link to that PR to see what the upstream says? And fi there is an upstream, why do we have it here too?

Also, you change client_http.hpp, do you need to change client_https.hpp too? Or they are totally different files?

@greenscientist
Copy link
Contributor Author

Upstream PR: https://gitlab.com/eidheim/Simple-Web-Server/-/merge_requests/279

We do it here since for that project it's customary to copy the simple file into the project. We also have some local modifications I think.

We don't need to change client_https.hpp, it uses the content of client_http.hpp

Copy link
Collaborator

@tahini tahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I you say so!

@greenscientist greenscientist merged commit b8a38cf into chairemobilite:v2c Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants