Export functions in exportAllToCsvByObject #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to export because we used some of these functions in other survey, and we want to only maintain one function.
tahini
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Ceci pourrait être une solution correcte dans la branche 0.3.0 pour que les surveys puissent y accéder. Par contre dans main, si elles étaient internes, c'est parce qu'on les utilisaient uniquement dans cet export spécifique. Si on en a besoin pour d'autres exports, il faudrait les mettre dans un fichier séparé, un genre de librairie d'export ou de transformation de données, avec des tests unitaires complets de ces fonctions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Export functions in exportAllToCsvByObject
We need to export because we used some of these functions in other survey, and we want to only maintain one function.