Update base survey objects for serialized data #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaligrafy
force-pushed
the
updateBaseSurveyObjectsForSerializedData
branch
from
ee53971 to
ded394a
Compare
kaligrafy
force-pushed
the
updateBaseSurveyObjectsForSerializedData
branch
4 times, most recently
from
d7282cc to
1c92cfa
Compare
tahini
reviewed
Feb 9, 2024
| @@ -0,0 +1,14 @@ | |||
| // can return invalid dates: use isNaN on date.getTime() to check if it's valid | |||
There was a problem hiding this comment.
Please add unit tests for this file, it's a util after all!
|
|
||
| // Validate baseVehicles (if provided) | ||
| if ( | ||
| dirtyParams.baseVehicles !== undefined && |
There was a problem hiding this comment.
Where are those validations now?
There was a problem hiding this comment.
they were never used, this was base object composition, which should not happen. We will composed only custom objects in survey itself.
kaligrafy
force-pushed
the
updateBaseSurveyObjectsForSerializedData
branch
from
1c92cfa to
9390a0c
Compare
tahini
requested changes
Feb 9, 2024
| @@ -0,0 +1,14 @@ | |||
| // can return invalid dates: use isNaN on date.getTime() to check if it's valid | |||
There was a problem hiding this comment.
Please add unit tests for this file, it's a util after all!
kaligrafy
force-pushed
the
updateBaseSurveyObjectsForSerializedData
branch
from
44d8505 to
dcb91c3
Compare
tahini
approved these changes
Feb 9, 2024
tahini
approved these changes
Feb 9, 2024
kaligrafy
force-pushed
the
updateBaseSurveyObjectsForSerializedData
branch
from
dcb91c3 to
9d874cb
Compare
tahini
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.