audits: Use new audit table for audit filter #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The audit filter uses a subquery to the sv_audits table instead of the audits field of the interviews table. The list of validation errors come from the sv_audits table as well. Sequential tests are updated accordingly.
tahini
force-pushed
the
updateAuditFilter
branch
from
30d78cf to
c87067d
Compare
kaligrafy
approved these changes
Jan 29, 2024
|
This PR adds a subquery to the validation list query. I expect performances will be degraded a bit in our production surveys, but by how much, I am not sure. @kaligrafy, if you have the opportunity, can you try this PR on the complete database and confirm that performances are not so bad, or au contraire, it's impossible to run? |
|
I'll merge and when/if performance becomes a problem, we can revisit the queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audit filter uses a subquery to the sv_audits table instead of the audits field of the interviews table.
The list of validation errors come from the sv_audits table as well.
Sequential tests are updated accordingly.