Migrate Generator to Evolution #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
tahini
reviewed
Jan 17, 2024
tahini
reviewed
Jan 17, 2024
samuel-duhaime
force-pushed
the
addGenerator
branch
from
11847bc to
6a8508b
Compare
tahini
requested changes
Feb 5, 2024
packages/evolution-common/src/services/surveyGenerator/common/defaultConditional.tsx
Show resolved
Hide resolved
samuel-duhaime
force-pushed
the
addGenerator
branch
from
9aaa71a to
ad7939a
Compare
tahini
approved these changes
Feb 5, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am aware that there are still many corrections to be made. I think the practical way is to do a good review now, and we will make pull requests for each of the major aspects to improve.
This way, the next fixes will be smaller (and easier to review), and we will have a better overview of Generator. We will also be able to test Generator with the next new surveys that come.