-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L2Block #1825
base: nightly
Are you sure you want to change the base?
L2Block #1825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR
|
||
/// Signed L2 header | ||
#[derive(PartialEq, Eq, BorshDeserialize, BorshSerialize, Serialize, Deserialize, Clone, Debug)] | ||
pub struct SignedSoftConfirmationHeader { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just Header
or L2Header
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Show resolved
Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looking good
crates/fullnode/src/db_migrations/soft_confirmation_tx_merkle_root.rs
Outdated
Show resolved
Hide resolved
20c0adc
to
24b72e7
Compare
crates/common/src/db_migrations/soft_confirmation_tx_merkle_root.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/zk/batch_proof/input/mod.rs
Outdated
Show resolved
Hide resolved
…new-block-format
…new-block-format
Description
SignedSoftConfirmation
intoL2Block
. Extract txs out of block and follow a consistent header/tx split.tx_merkle_root
to headertx_merkle_root
toStoredSoftConfirmation
SoftConfirmationReceipt
Linked Issues