Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stored tx hashes #1824

Closed
wants to merge 1 commit into from
Closed

Use stored tx hashes #1824

wants to merge 1 commit into from

Conversation

jfldde
Copy link
Contributor

@jfldde jfldde commented Feb 6, 2025

Description

  • Extract tx hashes out of SoftConfirmationResponse before converting to SignedSoftConfirmation
  • Don't re-compute stored tx hashes

@jfldde jfldde requested a review from eyusufatik as a code owner February 6, 2025 16:58
@auto-assign auto-assign bot requested a review from ercecan February 6, 2025 16:58
@jfldde
Copy link
Contributor Author

jfldde commented Feb 6, 2025

Closing and merging directly in PR for #1766

@jfldde jfldde closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyusufatik eyusufatik Awaiting requested review from eyusufatik eyusufatik is a code owner

@ercecan ercecan Awaiting requested review from ercecan

Assignees

@jfldde jfldde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfldde