Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short form da proof #1822

Merged
merged 5 commits into from
Feb 6, 2025
Merged

short form da proof #1822

merged 5 commits into from
Feb 6, 2025

Conversation

eyusufatik
Copy link
Member

Description

Closes #1772

@auto-assign auto-assign bot requested a review from jfldde February 6, 2025 14:01
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 93.26923% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.6%. Comparing base (1a9c200) to head (4bd19bb).
Report is 3 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/bitcoin-da/src/spec/short_proof.rs 95.8% 7 Missing ⚠️
...ates/sovereign-sdk/adapters/mock-da/src/service.rs 0.0% 4 Missing ⚠️
...tes/sovereign-sdk/adapters/mock-da/src/verifier.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/bitcoin-da/src/helpers/merkle_tree.rs 95.3% <100.0%> (ø)
crates/bitcoin-da/src/service.rs 75.8% <100.0%> (+0.9%) ⬆️
crates/bitcoin-da/src/spec/header.rs 79.4% <ø> (+3.8%) ⬆️
crates/bitcoin-da/src/spec/mod.rs 0.0% <ø> (ø)
crates/bitcoin-da/src/verifier.rs 76.7% <100.0%> (ø)
...reign-sdk/rollup-interface/src/node/services/da.rs 0.0% <ø> (ø)
...reign-sdk/rollup-interface/src/state_machine/da.rs 72.7% <ø> (ø)
...tes/sovereign-sdk/adapters/mock-da/src/verifier.rs 70.6% <0.0%> (-3.0%) ⬇️
...ates/sovereign-sdk/adapters/mock-da/src/service.rs 93.8% <0.0%> (-0.2%) ⬇️
crates/bitcoin-da/src/spec/short_proof.rs 95.8% <95.8%> (ø)

... and 7 files with indirect coverage changes

@eyusufatik eyusufatik merged commit 2824f46 into nightly Feb 6, 2025
14 checks passed
@eyusufatik eyusufatik deleted the esad/short-form-da-proof branch February 6, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Short Form DAVerifier without blob extraction
3 participants