-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ECDSA/k256 for sov signatures #1798
Open
ercecan
wants to merge
41
commits into
nightly
Choose a base branch
from
erce/use-k256-for-sov-signatures
base: nightly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ercecan
changed the title
Erce/use k256 for sov signatures
Use ECDSA/k256 for sov signatures
Feb 3, 2025
kpp
reviewed
Feb 4, 2025
kpp
reviewed
Feb 4, 2025
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/stf_blueprint.rs
Outdated
Show resolved
Hide resolved
kpp
reviewed
Feb 7, 2025
kpp
reviewed
Feb 7, 2025
eyusufatik
requested changes
Feb 11, 2025
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/lib.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/zk/batch_proof/output/v3.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/module-implementations/sov-accounts/src/hooks.rs
Outdated
Show resolved
Hide resolved
kpp
approved these changes
Feb 11, 2025
…y constants in guest
eyusufatik
approved these changes
Feb 12, 2025
crates/sovereign-sdk/rollup-interface/src/state_machine/zk/batch_proof/input/mod.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/lib.rs
Outdated
Show resolved
Hide resolved
let transaction = | ||
Transaction::<C>::new_signed_tx(&self.sov_tx_signer_priv_key, raw_message, 0, nonce); | ||
borsh::to_vec(&transaction).map_err(|e| anyhow!(e)) | ||
// TODO: Should this be >= Fork2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it should be no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses k256 after fork2 instead of dalek signatures
With this pr we will be getting rid of sha 512 after fork2 and we will be using k256 signatures.
Main reason to do this is ABOUT 10% our cycles are coming form Dalek signatures and sha512, and risc0 has k256 accelerator so our cycles will drop quite a bit.
Linked Issues
Benchmark
Some stats with 3055 txs in around 15 blocks:
Nightly:
this pr:
with 3055 txs in around 15 blocks we can see ~3.5% drop in cycle counts, this drop will be much more in real scenarios when txs are more spread to more blocks, instead 3000 txs being compressed to 15 blocks like in this case.