Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override compute_wtxid() and compute_txid() functions with patched sha256 impl #1715

Open
wants to merge 6 commits into
base: nightly
Choose a base branch
from

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Jan 15, 2025

Description

Use our calculate_double_sha256() to compute txid/wtxid in zk context.

Linked Issues

@kpp kpp requested a review from eyusufatik as a code owner January 15, 2025 22:45
@auto-assign auto-assign bot requested a review from ercecan January 15, 2025 22:45
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.2%. Comparing base (1265a26) to head (537e153).

Additional details and impacted files
Files with missing lines Coverage Δ
crates/bitcoin-da/src/helpers/merkle_tree.rs 95.3% <100.0%> (ø)
crates/bitcoin-da/src/helpers/mod.rs 88.8% <100.0%> (+8.1%) ⬆️
crates/bitcoin-da/src/verifier.rs 76.8% <100.0%> (-0.2%) ⬇️

... and 2 files with indirect coverage changes

@eyusufatik eyusufatik added the HOLD-MERGE PR is not draft but should not be merged yet label Jan 16, 2025
@eyusufatik
Copy link
Member

hold-merge label for two reasons:

  • @kpp wants to write unit tests for the new functions.
  • if we merge this now, the batch proof elfs on testnet and devnet will defer in behaviour -- which might be ok, need to think about it.

@kpp kpp force-pushed the kpp/opt_txid_wtxid branch from 490c405 to 595bdcc Compare January 17, 2025 01:08
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aproving but don't merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HOLD-MERGE PR is not draft but should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override compute_wtxid() and compute_txid() functions with patched sha256 impl.
2 participants