Sort commitments in zk (#987)

* Sort commitments in zk

* Impl Ord for commitment

* Replace std with core

---------

Co-authored-by: yaziciahmet <yaziciahmetcleargmail.com>

crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/lib.rs

@@ -522,6 +522,9 @@ where
             }
         }
 
+        // Sort commitments just in case
+        sequencer_commitments.sort_unstable();
+
         // Then verify these soft confirmations.
 
         let mut current_state_root = initial_state_root.clone();

crates/sovereign-sdk/rollup-interface/src/state_machine/da.rs

@@ -21,6 +21,18 @@ pub struct SequencerCommitment {
     pub l2_end_block_number: u64,
 }
 
+impl core::cmp::PartialOrd for SequencerCommitment {
+    fn partial_cmp(&self, other: &Self) -> Option<core::cmp::Ordering> {
+        Some(self.cmp(other))
+    }
+}
+
+impl core::cmp::Ord for SequencerCommitment {
+    fn cmp(&self, other: &Self) -> core::cmp::Ordering {
+        self.l2_start_block_number.cmp(&other.l2_start_block_number)
+    }
+}
+
 /// Data written to DA can only be one of these two types
 /// Data written to DA and read from DA is must be borsh serialization of this enum
 #[derive(Debug, Clone, Serialize, Deserialize, Eq, PartialEq, BorshDeserialize, BorshSerialize)]