Container name for task, based on node config job_manager_host #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day!
Glad to see v0.2.X as new mainline. Current PR is focused to reduce duplication of places where we specify jobmanager_host.
Current status
Three points where something could go wrong. So main goal to reduce config points to minimal.
My propose in PR
After that we only need to setup docker-compose.yml, node.yaml without braking code at all. It's more logical to attach container name to node config, rather than using static value, which can broke by docker compose, which has weak relation to node service at all.
If this PR is acceptable, my next propose will be, move jobmanagers container_name and hostname to .env, to get single point of control for job_manager_host, besides node.yaml. This is valid for docker-compose, nomad, kubernetes, and can be well documented too.