Integrated chai-subset and added assert-based negation to containSubset
#1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
reviewed
Jan 18, 2025
| @@ -0,0 +1,206 @@ | |||
| import {assert, expect} from '../index.js'; | |||
|
|
|||
| describe('plain object', function () { | |||
There was a problem hiding this comment.
this file should have a root describe('containsSubset', ...) block which these all live below
43081j
reviewed
Jan 18, 2025
| if (typeof expected !== 'object' || expected === null) { | ||
| return expected === actual; | ||
| } | ||
| if (!!expected && !actual) { |
There was a problem hiding this comment.
at this point, we already know expected is an NonNull<object> and actual is object, so you can avoid the !!
Suggested change
| if (!!expected && !actual) { | |
| if(!actual) { | |
| return false; | |
| } |
43081j
reviewed
Jan 18, 2025
| if (typeof actual.length !== 'number') { | ||
| return false; | ||
| } | ||
| var aa = Array.prototype.slice.call(actual); |
There was a problem hiding this comment.
is there a reason we clone the array? and why we don't use Array.isArray(actual) above?
|
we should also add tests for using this with should and assert style assertions otherwise looks good so far though 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revival of @koddsson 's previous attempt at merging the abandoned
chai-subsetfunctionality, with some added comments and an assert-style negation of containSubset which was not present in the original package. I know there was some concern about code duplication in the original PR, so I'm happy to respond to feedback! Thanks all.Fixes #1616