Refactor AMR code to use new generic interface #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change struct fields to prep for generic AMR implementation.
`linear_amr_test_new.jl` covers all cases from previous `linear_amr_test.jl` and cases from `mzr_test.jl`. Since the linear AMR tests are fairly exhaustive WRT to the AMR API, we perhaps don't need as many tests for the logarithmic AMR model. Maybe just test things like calculate coeffs, make sure `fg!` runs, and so on?
During linesearch for BFGS it is possible for the algorithm to try a combination of slope and intercept that results in negative mass fractions, which causes `log10` to throw errors and interrupt the algorithm. We can avoid this scenario by returning `NaN` out of `MH_from_Z` instead of allowing `log10` to error.
Tried using chunking method but resulted in short MC chains with significant autocorrelations. Sticking to one chain per thread, even though it is slower on inhomogenous architectures. Also switched to `Iterators.partition` over my manual work assignment strategy.
Merged
cgarling
referenced
this pull request
Mar 3, 2025
Removes the old AMR API. This version (1.0) will be the reference for the code version used in the paper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.