Split ProwJob volumes into presets

[irbekrm]

This PR:

• splits volumes for ProwJob configs into presets so there is less of a chance of human error when copy-pasting jobs around
• fixes two such errors where a volume was duplicated here and here

I have checked that the presets get merged as expected by checking some of the job configs with mkpj:

• clone https://github.com/kubernetes/test-infra
• from within that repo run go run ./prow/cmd/mkpj/main.go --config-path=<path to jetstack/testing/config/config.yaml> --job-config-path=<path to jetstack/testing/config/jobs/cert-manager> --job <job-name>
• observe that the output ProwJob yaml contains the expected volumes and volume mounts

Signed-off-by: irbekrm [email protected]

[irbekrm]

I've created a couple cleanup issues from this #690, #691

[SgtCoDFish]

❤️ ❤️

This is awesome, such a huge readability improvement 👍

I've not checked all of the changes really closely - I assume they'll work, and if they don't I'll happily review any fixes.

Great stuff 🎉

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/cert-manager/OWNERS [SgtCoDFish,irbekrm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SgtCoDFish]

/lgtm

[jetstack-bot]

@irbekrm: Updated the job-config configmap in namespace default at cluster default using the following files:

• key cert-manager-periodics.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-periodics.yaml
• key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-presubmits.yaml
• key cert-manager-release-previous-periodics.yaml using file config/jobs/cert-manager/cert-manager/release-previous/cert-manager-release-previous-periodics.yaml
• key cert-manager-release-previous-presubmits.yaml using file config/jobs/cert-manager/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml
• key config.yaml using file config/jobs/cert-manager/config.yaml

In response to this:

This PR:

• splits volumes for ProwJob configs into presets so there is less of a chance of human error when copy-pasting jobs around
• fixes two such errors where a volume was duplicated here and here

I have checked that the presets get merged as expected by checking some of the job configs with mkpj:

• clone https://github.com/kubernetes/test-infra
• from within that repo run go run ./prow/cmd/mkpj/main.go --config-path=<path to jetstack/testing/config/config.yaml> --job-config-path=<path to jetstack/testing/config/jobs/cert-manager> --job <job-name>
• observe that the output ProwJob yaml contains the expected volumes and volume mounts

Signed-off-by: irbekrm [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.