Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Fix for Growth Chart’s print functionality being extremely slow in IE. #15

Merged

Conversation

shriniketsarkar-zz
Copy link

Issue : The open source version of growth chart pops out a window for the print functionality. When the application is run in IE, launching the print window opens up the pop-up but the content is rendered extremely slow. This results in the user staring at a blank page for several seconds and sometimes minutes before any UI gets rendered on the screen. This gives the user an impression that the UI is stuck.
More Info on this Issue : smart-on-fhir#26
Fix : This PR fixes the slowness issue. The fix involves loading content on the popup window from the main growth chart window.
Changes :

  1. A new gc-print.html page is loaded when we click on the Print Icon on Main window.
  2. The Main GC window uses the rendered "Graph" and "Parent" views from the main window to be shown on the print popup based on the selection on the main window. If "Table" view is selected on the main window we redraw the table in a vertical orientation on the print popup.
    **Printing Considerations : **
    The user will need to print in landscape mode for Graph and Parent views where as portrait mode can be used for Table view.

@kpshek
@zplata
@mjhenkes
@kolkheang

@koushic88
Copy link

+1

</div>
<div id="container">
<div id="header">
<h1 class="patient-name" data-translatecontent="STR_6021">Patient`s name</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tick mark on Patients` is not the correct one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was carried forward from the existing print window.
Checked with @kolkheang and wont be making any change for this as we want to retain whatever we can from the existing print functionality.

@shriniketsarkar-zz shriniketsarkar-zz merged commit 4061014 into cerner/dstu2 Oct 31, 2017
@shriniketsarkar-zz shriniketsarkar-zz deleted the GC_PrintingPopupSlownessIE_Fix_Issue_26 branch November 1, 2017 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants