Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCSC notebook example for TXND #310

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Add DCSC notebook example for TXND #310

merged 6 commits into from
Mar 26, 2024

Conversation

bzah
Copy link
Member

@bzah bzah commented Mar 26, 2024

Pull Request to resolve #xxx

  • Unit tests cover the changes.
  • These changes were tested on real data.
  • The relevant documentation has been added or updated.
  • A short description of the changes has been added to doc/source/references/release_notes.rst.

Describe the changes you made

  • added notebook for txnd.
  • Fixed update logo script.
  • Move frequency module to public api. This is necessary because slice_mode parameter can be a Frequency.
  • Migrate AS frequencies to YS as per pandas latest change.
  • Update signature of normal based indices in icclim.dcsc module.

No changelog update as this is just a small addition to v7.0.0 that is to be released.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Mar 26, 2024

Coverage

Report
FileStmtsMissCoverMissing
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim
   frequency.py1801393%39–41, 258–261, 449–453, 470, 553–557, 579, 584
   logger.py862966%24, 44, 66, 71–96, 106, 112–143, 151–156
   main.py2703288%60–70, 131, 140, 491–492, 658–659, 727, 753–754, 756–757, 759, 761–762, 764–765, 789–796, 866–871
   rechunk.py90792%29–32, 126, 228–229, 233
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/_core
   climate_variable.py992080%31–42, 156–162, 264–265, 367–368, 377, 411, 421–422
   input_parsing.py2636376%28–37, 92–93, 97–98, 103–108, 140–141, 269, 274–278, 281, 301–305, 307–308, 349–350, 402–406, 409, 463, 534–539, 543, 545, 635, 686, 692–700, 731, 735–739, 754–758, 785, 799, 804–809, 816–821, 832–833, 837–844, 860
   utils.py14286%30–35
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/_core/generic
   functions.py3198374%54–63, 154, 238–239, 980–981, 987, 1021, 1027, 1081–1085, 1087–1088, 1106–1112, 1116, 1169, 1171, 1234–1235, 1244–1270, 1298–1318, 1334, 1342–1374, 1380–1383
   indicator.py1501789%36–41, 158–161, 165, 408, 416–420, 422–426, 461, 507–508, 530
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/_core/generic/threshold
   basic.py104892%31–34, 72, 172–173, 198, 324
   bounded.py551376%23–29, 54–56, 84–88, 92–96, 227
   percentile.py1341390%40–47, 215–216, 339–344, 458–460
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/_core/legacy/user_index
   model.py20200%3–43
   parse.py851582%21–26, 60–61, 79, 86, 90–94, 204, 229, 235–236
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/_core/model
   cf_calendar.py35197%63
   global_metadata.py660%3–23
   icclim_types.py14140%3–25
   in_file_dictionary.py990%3–46
   index_config.py31681%13–18
   indicator.py36878%10–11, 23, 28, 67, 72, 77, 82
   logical_link.py21195%14
   operator.py32391%13, 18–22
   standard_index.py36975%9–16, 68, 72, 77
   standard_variable.py48198%48
   threshold.py541081%15–25, 95, 100, 149
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/_generated
   _dcsc.py1015546%20–29, 133, 214, 295, 404, 524, 644, 764, 856, 940, 1024, 1108, 1192, 1389–1395, 1489–1495, 1589–1595, 1689–1695, 1776, 1860, 1944, 2025, 2109, 2190, 2274, 2358, 2442, 2554, 2675, 2796, 2917, 3025, 3135
   _ecad.py144894%19–28
   _generic.py591083%18–29
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/ecad
   binding.py58886%15–17, 45, 49, 86, 90, 127, 131
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/generic
   registry.py41490%39, 46–47, 69
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/icclim/threshold
   factory.py1691293%38, 177–178, 255, 279–280, 285, 355–356, 359–363, 403
TOTAL310150084% 

Test results

Tests Skipped Failures Errors Time
196 0 💤 0 ❌ 0 🔥 1m 57s ⏱️

@bzah bzah merged commit d11c778 into master Mar 26, 2024
5 checks passed
@bzah bzah deleted the maint/various_changes branch March 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant