Compatibility fix of centos release version

[Zhiwei-Dai]

    modified:   ceph_deploy/hosts/centos/__init__.py

Fix: https://tracker.ceph.com/issues/44365

Signed-off-by: Dai Zhiwei [email protected]
Signed-off-by: luo rixin [email protected]

[ceph-jenkins]

Can one of the admins verify this patch?

[Zhiwei-Dai]

@alfredodeza, i was wondering if u could review the pr, ths

[HacKanCuBa]

Hello! Quick question: why are you printing the file error? I mean, what is the user supposed to do with that information?
On the other hand, would you consider using open as context manager?

PS: not a maintainer, just someone like you.

[Zhiwei-Dai]

Ths your question.
when follow three 'if' have right 'return' type , the printing info just show a fact.
if can't return right type, the printing provides infos to enhance compatibility of derivative os release.
eg. Here is an Linux distribution os AOS 2.0 which is close to CentOS 7. if macros.dist opening error, we can make this file and define the macro like:

# dist macros.
%centos 7

Well, context manager is a nice choice.

Hello! Quick question: why are you printing the file error? I mean, what is the user supposed to do with that information?
On the other hand, would you consider using open as context manager?

PS: not a maintainer, just someone like you.

[HacKanCuBa]

Well, another thing I forgot to ask was: whenever that file exists and has the string centos in a given line, how sure are we that splitting by spaces and converting to int whatever comes next to centos is going to be OK and not explode? As in, are we sure something like centos-something cool won't exist in that file?
My point is whether exists or not a convention over that file. If there isn't, then we might want to catch the ValueError of int(...) or even IndexError of release_info[1].

[Zhiwei-Dai]

Usually, this file /etc/rpm/macros.dist is existing for rpm & distribution building. If not existing, maybe it is deleted by mistake.
Look this system file in centos7.6:

# dist macros.

%centos_ver 7
%centos 7
%rhel 7
%dist .el7
%el7 1

in euleros 2.0:

# dist macros.

%centos 7
%rhel 7
%dist %{nil}
%el7 1
%euleros 2

So, I mean different system files have different aspects. If something like centos-something cool exist in that file, we should discuss why it was here.

[Zhiwei-Dai]

@HacKanCuBa Well, when I switch to use context manager to open file, exception handling prompts me to catch the ValueError of int(...). Nice job.

[tchaikov]

i don't think we should rely on an rpm macro for determining the distro's release version. user does not necessarily have this package installed.

[alamintech]

I have some problem. I am used ceph storage for my CloudStack primary storage pool but after create vm then reboot ceph server osd service can't start. How can I solve this. this is ceph issue or cloudstack issue ? I am not sure. Please help me....Thanks.

[tchaikov]

I have some problem. I am used ceph storage for my CloudStack primary storage pool but after create vm then reboot ceph server osd service can't start. How can I solve this. this is ceph issue or cloudstack issue ? I am not sure. Please help me....Thanks.

@alamintech you might want to send you questions to ceph-user mailing list or the #ceph IRC channel instead. see https://ceph.io/irc/