Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: rename groupNamePrefix to volumeGroupNamePrefix #5063

Merged
merged 2 commits into from
Jan 9, 2025
Merged

rbd: rename groupNamePrefix to volumeGroupNamePrefix #5063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03f5326
rbd: rename groupNamePrefix to volumeGroupNamePrefix
iPraveenParihar Jan 8, 2025
2fa5d19
doc: update examples to use volumeGroupNamePrefix
iPraveenParihar Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/rbd/groupsnapshotclass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ parameters:
# eg: pool: rbdpool
pool: <rbd-pool-name>

# (optional) Prefix to use for naming RBD groups.
# If omitted, defaults to "csi-vol-group-".
# volumeGroupNamePrefix: "foo-bar-"

csi.storage.k8s.io/group-snapshotter-secret-name: csi-rbd-secret
csi.storage.k8s.io/group-snapshotter-secret-namespace: default
deletionPolicy: Delete
8 changes: 4 additions & 4 deletions internal/rbd/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,8 @@ func (mgr *rbdManager) GetVolumeGroupSnapshotByName(
return nil, errors.New("required 'pool' option missing in volume group parameters")
}

// groupNamePrefix is an optional parameter, can be an empty string
prefix := mgr.parameters["groupNamePrefix"]
// volumeGroupNamePrefix is an optional parameter, can be an empty string
prefix := mgr.parameters["volumeGroupNamePrefix"]

clusterID, err := util.GetClusterID(mgr.parameters)
if err != nil {
Expand Down Expand Up @@ -409,8 +409,8 @@ func (mgr *rbdManager) CreateVolumeGroupSnapshot(
return nil, err
}

// groupNamePrefix is an optional parameter, can be an empty string
prefix := mgr.parameters["groupNamePrefix"]
// volumeGroupNamePrefix is an optional parameter, can be an empty string
prefix := mgr.parameters["volumeGroupNamePrefix"]

clusterID, err := vg.GetClusterID(ctx)
if err != nil {
Expand Down
Loading