Apply TxFeeCap conversion #321
Open
+93
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezdac
requested changes
Feb 10, 2025
ezdac
requested changes
Feb 11, 2025
| rate, ok := rates[*feeCurrency] | ||
| if !ok { | ||
| return 0, fmt.Errorf("could not convert from native to fee currency (fee-currency=%s): %w ", feeCurrency, exchange.ErrUnregisteredFeeCurrency) | ||
| log.Warn("Failed to get exchange rates for latest block", "err", err) |
There was a problem hiding this comment.
I believe this is overly verbose - especially since this warning can't be correlated to the request arguments and failed RPC requests are already logged with additional request-context:
Lines 476 to 481 in 055f61b
So I'd just pass along the error, or wrap the error when the additional message should also be visible to the caller in the response.
| return 0, fmt.Errorf("failed to accurately convert fee currency to float64") | ||
| gasPriceInCelo, err := exchange.ConvertCurrencyToCelo(rates, feeCurrency, gasPrice) | ||
| if err != nil { | ||
| log.Warn("Failed to convert gas price", "err", err, "currency", feeCurrency) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #313
This PR adds fee cap conversion in
CheckTxFee.ConvertTxFeeCapToCurrencyfetches TxFeeCap from backend and convert it to a tx fee currency.