Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-publish-release.yaml #318

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Update docker-publish-release.yaml #318

merged 3 commits into from
Feb 4, 2025

Conversation

alvarof2
Copy link
Member

@alvarof2 alvarof2 commented Feb 3, 2025

Fix: remove unused job.

@alvarof2 alvarof2 requested a review from jcortejoso February 3, 2025 14:42
@palango
Copy link
Collaborator

palango commented Feb 3, 2025

@alvarof2 Can we tage the docker images with something like stable, latest as well? This would be helpful for people running a node.

And if the tag contains rc or beta, we might want tag the docker image as beta as well.

@piersy
Copy link

piersy commented Feb 3, 2025

@alvarof2 Can we tage the docker images with something like stable, latest as well? This would be helpful for people running a node.

And if the tag contains rc or beta, we might want tag the docker image as beta as well.

Can we just use the entire tag for the docker image, that way it's easy for people to know what tag relates to a docker image?

@palango
Copy link
Collaborator

palango commented Feb 3, 2025

@alvarof2 Can we tage the docker images with something like stable, latest as well? This would be helpful for people running a node.
And if the tag contains rc or beta, we might want tag the docker image as beta as well.

Can we just use the entire tag for the docker image, that way it's easy for people to know what tag relates to a docker image?

That as well, but it's good practice to also have stable point to the latest stable release.

@piersy
Copy link

piersy commented Feb 3, 2025

@alvarof2 Can we tage the docker images with something like stable, latest as well? This would be helpful for people running a node.
And if the tag contains rc or beta, we might want tag the docker image as beta as well.

Can we just use the entire tag for the docker image, that way it's easy for people to know what tag relates to a docker image?
This is what we have done so far, so for example this tag celo-v2.0.0-rc3 and this image us-west1-docker.pkg.dev/devopsre/celo-blockchain-public/op-geth:celo-v2.0.0-rc3

@alvarof2
Copy link
Member Author

alvarof2 commented Feb 3, 2025

The latest commit has this line tags: ${{ github.event.release.tag_name }},latest,stable that wouyld as the following tags:

  • ${{ github.event.release.tag_name }} -> the entire tag as requested by @piersy
  • latest and stable as requested by @palango

Please let me know if that's OK.

@palango
Copy link
Collaborator

palango commented Feb 4, 2025

  • latest and stable as requested by @palango

Can we just add that if the tag doesn't contain beta or rc?

@alvarof2
Copy link
Member Author

alvarof2 commented Feb 4, 2025

  • latest and stable as requested by @palango

Can we just add that if the tag doesn't contain beta or rc?

My friend ChatGPT says the latest commit will produce something like this:
Screenshot 2025-02-04 at 17 37 40

Would this be OK?

@palango
Copy link
Collaborator

palango commented Feb 4, 2025

My friend ChatGPT says the latest commit will produce something like this: Screenshot 2025-02-04 at 17 37 40

So this is your trick 🚀

Would this be OK?

Perfect!

@alvarof2 alvarof2 merged commit 3db0c2e into celo11 Feb 4, 2025
8 checks passed
@alvarof2 alvarof2 deleted the alvarof2-patch-1 branch February 4, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants