Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shrex): improve resource management #4067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DeVikingMark
Copy link

@DeVikingMark DeVikingMark commented Jan 25, 2025

Prevent resource leaks in shrex recovery middleware:

  • Add stream closure in panic recovery handler
  • Ensures proper cleanup of network resources in case of panics
  • Prevents potential resource leaks in error scenarios

@github-actions github-actions bot added the external Issues created by non node team members label Jan 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.80%. Comparing base (2469e7a) to head (4a1d93a).
Report is 431 commits behind head on main.

Files with missing lines Patch % Lines
share/shwap/p2p/shrex/recovery.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4067      +/-   ##
==========================================
- Coverage   44.83%   44.80%   -0.04%     
==========================================
  Files         265      308      +43     
  Lines       14620    22483    +7863     
==========================================
+ Hits         6555    10073    +3518     
- Misses       7313    11324    +4011     
- Partials      752     1086     +334     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants