refactor: improve error handling in LoadTxInfo #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiendn
requested review from
cmwaters and
rach-id
and removed request for
a team
rootulp
reviewed
Dec 20, 2024
store/store.go
Outdated
| } | ||
| if len(bz) == 0 { | ||
| return nil | ||
| return nil, nil |
There was a problem hiding this comment.
[question] should we return an error in this situation? Also needs a unit test.
There was a problem hiding this comment.
Yeah, I think it makes consistent.
There was a problem hiding this comment.
This still doesn't return an error. should it?
rootulp
changed the title
Yeah, i want to improve codebase |
|
I'll fixed test |
rootulp
reviewed
Dec 23, 2024
store/store.go
Outdated
| } | ||
| if len(bz) == 0 { | ||
| return nil | ||
| return nil, nil |
There was a problem hiding this comment.
This still doesn't return an error. should it?
|
Hi @rootulp, thank you for reviewing my PR. |
rootulp
reviewed
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve error handling in LoadTxInfo
Replace panic with proper error returns in LoadTxInfo function to follow Go's
error handling conventions. This change:
This is part of an ongoing effort to improve error handling patterns in the
codebase.
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments