Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rootul P <[email protected]>
  • Loading branch information
jcstein and rootulp authored Oct 16, 2024
1 parent 107de98 commit 2696f42
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cips/cip-26.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The motivation for this CIP stems from a discussion in Core Devs Call 17, where
## Specification

1. The block time in celestia-app SHOULD be reduced from 12 seconds to 6 seconds. Concretely, this implies decreasing `TimeoutCommit` to 4.2 seconds and `TimeoutPropose` to 3.5 seconds.
1. The `TimeoutCommit` and `TimeoutPropose` parameters were moved from local config parameters into versioned parameters controlled by the state machine to ensure consistency and correctness across different protocol versions. This change allows the system to adapt dynamically to version-specific requirements, improving overall stability and interoperability during upgrades.
1. The `TimeoutCommit` and `TimeoutPropose` parameters were moved from local config parameters into versioned parameters controlled by the state machine to ensure consistency and correctness across different protocol versions.
1. The change in block time MUST be implemented at a specific block height, which SHALL be determined and agreed upon by the Celestia community via on-chain signaling by validators.
1. Celestia consensus nodes SHOULD update their software to accommodate this change prior to the agreed-upon block height.
1. Client applications interacting with the Celestia network SHOULD be updated to account for the faster block time, particularly in areas related to transaction confirmation and block finality.
Expand All @@ -29,7 +29,7 @@ The motivation for this CIP stems from a discussion in Core Devs Call 17, where
1. Current default: `ttl-num-blocks = 5`
1. New default: `ttl-num-blocks = 12`
1. This change SHALL NOT be implemented alongside the block time reduction. The default increase from 5 to 12 will occur when users upgrade to v3.0.0 and regenerate their config files. The block time reduction will happen one week later when the v2 to v3 activation height occurs. This approach ensures consistent behavior of the mempool across the network upgrade.
1. All validator nodes MUST update their configuration files to reflect this new `ttl-num-blocks` value before the agreed-upon implementation block height.
1. All validator nodes SHOULD update their configuration files to reflect this new `ttl-num-blocks` value before the agreed-upon implementation block height.

1. Documentation and APIs related to block time and block production MUST be updated to reflect these changes.

Expand All @@ -55,7 +55,7 @@ While the reduction in block time itself does not introduce significant new secu
1. The increase of `ttl-num-blocks` from 5 to 12 is crucial for maintaining the security and efficiency of the mempool:
1. It prevents premature removal of valid transactions, reducing the risk of unintended exclusion from blocks.
1. Without this adjustment, transactions would be pruned from the mempool after only 30 seconds, potentially leading to increased transaction failures and a poor user experience.
1. Validators and node operators must update their configurations to reflect the new `ttl-num-blocks` value to maintain network consistency and security.
1. Validators and node operators should update their configurations to reflect the new `ttl-num-blocks` value to maintain network consistency and security.

These changes require careful implementation and testing to ensure network stability during and after the transition.

Expand Down

0 comments on commit 2696f42

Please sign in to comment.