chore(core)!: Align CloudException interface with stdlib.
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Celest vends its own `UnimplementedError` type which conforms to `CloudException` but it previously had a different interface than the `dart:core` type so if you imported Celest, any `UnimplementedError()` clauses would need to be changed. This aligns all exception type interfaces to avoid needing to pass explicit `null` to their constructors. Also fixes the `CloudException.http` and `CloudException.grpc` factories to pass all parameters to delegated constructors.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 14, 2024
Merged
Merged
kumamoto
approved these changes
Oct 14, 2024
This was referenced Oct 14, 2024
kumamoto
approved these changes
Oct 14, 2024
kumamoto
approved these changes
Oct 14, 2024
dnys1
deleted the
10-12-chore_core_align_cloudexception_interface_with_stdlib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celest vends its own
UnimplementedErrortype which conforms toCloudExceptionbut it previously had a different interface than thedart:coretype so if you imported Celest, anyUnimplementedError()clauses would need to be changed. This aligns all exception type interfaces to avoid needing to pass explicitnullto their constructors.Also fixes the
CloudException.httpandCloudException.grpcfactories to pass all parameters to delegated constructors.