Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #180

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

jasonray
Copy link

This set of updates will upgrade the fivebeans dependencies (which will get rid of all but one security finding).

@jasonray
Copy link
Author

Tests pass:

$ npm test

[email protected] test /Users/jasonray/code/fivebeans
nyc mocha -t 8000 -R spec test/

(node:79442) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
FiveBeansClient
#FiveBeansClient()
✓ creates a client with the passed-in options
#connect()
✓ creates and saves a connection
job producer:
✓ #use() connects to a specific tube
✓ #list_tube_used() returns the tube used by a producer
✓ #put() submits a job
job consumer:
✓ #watch() watches a tube
✓ #ignore() ignores a tube
✓ #list_tubes_watched() returns the tubes the consumer watches
✓ #peek_ready() peeks ahead at jobs
✓ #stats_job() returns job stats
✓ consumer can run stats_job() while a job is reserved
✓ #reserve() returns a job (1075ms)
✓ #touch() informs the server the client is still working
✓ #release() releases a job
✓ jobs can contain binary data
✓ jobs can contain utf8 data
✓ #peek_delayed() returns data for a delayed job
✓ #bury() buries a job (> 1sec expected) (1067ms)
✓ #peek_buried() returns data for a buried job
✓ #kick() un-buries jobs in the producer's used queue
✓ #kick_job() kicks a specific job id
✓ #pause_tube() suspends new job reservations (> 1sec expected) (1074ms)
✓ #destroy() deletes a job (nearly 2 sec expected) (1997ms)
✓ #reserve_with_timeout() times out when no jobs are waiting (> 1sec expected) (1074ms)
server statistics
✓ #stats() returns a hash of server stats
✓ #list_tubes() returns a list of tubes
✓ #stats_tube() returns a hash of tube stats
✓ #stats_tube() returns not found for non-existent tubes
concurrent commands
✓ can be handled

FiveBeansRunner
constructor
✓ throws when not given an id (86ms)
✓ throws when not given a config path (80ms)
✓ throws if given a config path that does not exist
✓ creates a runner when given valid options
readConfiguration()
✓ throws when the config requires non-existing handlers
✓ returns a config object for a good config
createWorker()
✓ returns a worker
✓ started the worker (1073ms)
go()
✓ creates and starts a worker

FiveBeansWorker
constructor
✓ creates a worker with the passed-in options
✓ inherits from EventEmitter
✓ respects the timeout option
starting & stopping
✓ emits the error event on failure
✓ emits the started event on success
✓ stops and cleans up when stopped (1070ms)
✓ watches tubes on start (1073ms)
job processing
✓ deletes jobs with bad formats (503ms)
✓ buries jobs with bad json
✓ buries jobs for which it has no handler
✓ passes good jobs to handlers
✓ handles jobs that contain arrays (for ruby compatibility)
✓ buries jobs when the handler responds with "bury"
✓ successfully handles jobs with non-ascii characters
✓ can call touch() on jobs in progress (5004ms)
✓ releases jobs when the handler responds with "release"
log events
- have tests

54 passing (15s)
1 pending

The current travis-ci build is failing to start `beanstalkd`.  This is because the argument `-d` is not recognized by the `beanstalkd` application (perhaps it was in a previous version of beanstalk?).  I switched to start `beanstalkd` in the background using `&` which likely achieve the same intent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant