Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dial down perf test #2444

Closed
wants to merge 3 commits into from
Closed

Dial down perf test #2444

wants to merge 3 commits into from

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Feb 6, 2025

Summary | Résumé

The perf test now causes a lot of 500 and other errors when it runs :/ This PR scales it back until we can properly investigate.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

After it runs check for staging errors around 7 pm EST.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels marked this pull request as ready for review February 6, 2025 19:15
@sastels
Copy link
Collaborator Author

sastels commented Feb 7, 2025

Let's fix Notify instead of reducing the tests!

@sastels sastels closed this Feb 7, 2025
@sastels sastels deleted the dial-down-perf-test branch February 7, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant