Add feedback_reason
column to the notification table
#2443
+49
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR adds a new column,
feedback_reason
, to the notifications table. It will be leveraged to track more granular reasons why a notification fails. It also adds a new notification_statuspinpoint-failure
.E.g. boto validates that the requested resource on AWS can handle the request being made through it. Since we disabled international sending in Pinpoint boto will throw an exception.
Related context that led to this decision
Test instructions | Instructions pour tester la modification
flask db upgrade
andflask db downgrade
work locallyRelease Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur