chore: fix integ test workflow to avoid possible race condition #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Between approval of the integ test deployment and the GH Actions runner picking up the job, the contents of the referenced branch could change because `pull_request.head.ref` is mutable. Using `sha` instead which is immutable. This PR also updates the action versions for this workflow.
mrgrain
temporarily deployed
to
IntegTestCredentials
GitHub Actions
Inactive
kaizencc
approved these changes
Apr 10, 2024
cdklabs-automation
deleted the
mrgrain/chore/fix/integ-test-workflow-race-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between approval of the integ test deployment and the GH Actions runner picking up the job, the contents of the referenced branch could change because
pull_request.head.refis mutable. Usingshainstead which is immutable.This PR also updates the action versions for this workflow.