fix: upgrade the update-feed and package-stats functions to SDK v3 #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/update-feed-sdk-v3
branch
from
2e0d193 to
6e3d5f2
Compare
mrgrain
changed the title
mrgrain
changed the title
otaviomacedo
approved these changes
Sep 12, 2024
Refactor the update-feed function to use AWS SDK v3. Tests updated accordingly.
mrgrain
force-pushed
the
mrgrain/fix/update-feed-sdk-v3
branch
from
6e3d5f2 to
79ba526
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…tes (#1453) In #1451 the update-feed function was migrated to SDK v3. For the migration the error handling needed to be adapted to SDK v3. With SDK v2 we checked for a `404` error status to conclude that no release notes are available. SDK v3 does not use http error codes, so we needed to convert to error names/types. Initially this was incompletely changed to only check for a `NotFound` error. However it also needs to check for `NoSuchKey` error. This has been fixed and the testcase updated. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the update-feed and package-stats functions to use AWS SDK v3. Tests updated accordingly.
Migrated these two together because they both needed a change to the catalog-builder client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license