Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema validation is broken on node 16 #120

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: schema validation is broken on node 16 #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .projen/deps.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .projen/tasks.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion .projenrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,12 @@ export const project = new cdk.JsiiProject({
jestVersion: '29',
},
srcdir: 'lib',
bundledDeps: ['jsonschema', 'semver'],
bundledDeps: [
// restricting to minor 4 because of https://github.com/tdegrunt/jsonschema/issues/405
// which breaks our canaries on node 16.
'jsonschema@~1.4.1',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not great but this is currently breaking our customers and I don't want to wait on an upstream fix.

'semver',
],
description: 'Cloud Assembly Schema',
devDeps: ['@types/semver', 'mock-fs', 'typescript-json-schema', 'tsx'],
gitignore: ['.DS_Store', '**/*.d.ts', '**/*.js'],
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading