Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundled dependencies should lead to a Yarn nohoist directive #760

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 30, 2025

Without this directive, the dependency will be hoisted to a top-level node_modules directory, but if it's there NPM will not bundle it when running npm pack.

Without this directive, the dependency will be hoisted to a top-level
`node_modules` directory, but if it's there NPM will not bundle it
when running `npm pack`.
@rix0rrr rix0rrr requested a review from a team January 30, 2025 20:45
Signed-off-by: github-actions <[email protected]>
@cdklabs-automation cdklabs-automation added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 49e85be Jan 30, 2025
6 checks passed
@cdklabs-automation cdklabs-automation deleted the huijbers/nohoist branch January 30, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants