feat(lambda): add isIterator prop #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've received feedback that the default IteratorAge widget is largely useless for any Lambda function that isn't actually a stream handler. Function doesn't provide a way to really tell if that's the case, so we ended up with an explicit prop. We default to true for backwards compat.
echeung-amzn
force-pushed
the
lambda-non-iterator
branch
from
86ebe12 to
768cb58
Compare
cayman-amzn
approved these changes
Sep 9, 2024
Comment on lines
+510
to
+512
| throw new Error( | ||
| "addMaxIteratorAgeAlarm is not applicable if isIterator is not true", | ||
| ); |
There was a problem hiding this comment.
I feel I've asked this before, so sorry in advance if i have
Can we use Annotations here? Having the scope included (via Annotations.error(...)) really helps folks find where in their app this is being thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've received feedback that the default IteratorAge widget is largely useless for any Lambda function that isn't actually a stream handler. Function doesn't provide a way to really tell if that's the case, so we ended up with an explicit prop.
We default to true for backwards compat.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license