Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wafv2): better handle contextually required region prop #535

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat(wafv2): better handle contextually required region prop #535

merged 1 commit into from
Jul 3, 2024

Conversation

echeung-amzn
Copy link
Member

  1. Throw an error at build time if we're missing the prop when it's needed.
  2. Automatically get the region when needed when using monitorScope.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@echeung-amzn echeung-amzn added the do-not-merge Label to signify Mergify to not auto-merge. Useful for grouping PR merges into a single release. label Jun 25, 2024
@echeung-amzn echeung-amzn merged commit c17e2b5 into cdklabs:main Jul 3, 2024
9 checks passed
@echeung-amzn echeung-amzn deleted the waf-region branch July 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayush987goyal ayush987goyal ayush987goyal approved these changes

@cayman-amzn cayman-amzn Awaiting requested review from cayman-amzn

Assignees
No one assigned
Labels
do-not-merge Label to signify Mergify to not auto-merge. Useful for grouping PR merges into a single release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echeung-amzn @ayush987goyal