feat: allow specifying regions/accounts at a more granular level #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeung-amzn
force-pushed
the
more-regions
branch
from
8935e88 to
670b84c
Compare
echeung-amzn
added a commit
that referenced
this pull request
Jun 25, 2024
So we can later use it for #533. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
echeung-amzn
force-pushed
the
more-regions
branch
6 times, most recently
from
f8539b4 to
e845d15
Compare
echeung-amzn
added
the
do-not-merge
echeung-amzn
force-pushed
the
more-regions
branch
2 times, most recently
from
a482960 to
256985d
Compare
echeung-amzn
added a commit
that referenced
this pull request
Jul 3, 2024
This is a continuation of #534, but it includes breaking changes to some existing metric factories' constructor API contracts. Also includes some minor private method renaming for consistency and a basic facade test, pulled out from #533. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
echeung-amzn
force-pushed
the
more-regions
branch
2 times, most recently
from
52c95b0 to
ebe6deb
Compare
echeung-amzn
force-pushed
the
more-regions
branch
from
ebe6deb to
1feedef
Compare
--- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
echeung-amzn
force-pushed
the
more-regions
branch
from
1feedef to
7024e95
Compare
ayush987goyal
approved these changes
Jul 3, 2024
echeung-amzn
added a commit
that referenced
this pull request
Aug 1, 2024
Addressing a few misses from #533. Also updates the test in `MonitoringFacade.test.ts` since XAXR alarms aren't possible. Fixes #434, but only in cases where we can infer that the account/region is actually different from the construct scope to prevent unnecessary XAXR alarm errors. Fixes #428, in cases where the account/region is actually different from the construct scope. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
echeung-amzn
added a commit
that referenced
this pull request
Aug 1, 2024
…r dashboards (#551) Building on top of #533, but `monitorCustom` has its own API for simplifying search expression queries so we need to explicitly handle it. Regular `new Metric(...)` calls just pass in the `account`/`metric` via that API. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to target different regions/account for specific things within a facade rather than relying on 1 facade per region/account with the facade's global settings, so something like:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license