Skip to content

Commit

Permalink
fix: Add sampleCountMetricId to CustomAlarmThreshold (#581)
Browse files Browse the repository at this point in the history 
This provides support for `minSampleCountToEvaluateDatapoint` when using eg. `ErrorAlarmFactory`. Without this change and with a `MathExpression` containing multiple metrics, one would get the following error:

> "sampleCountMetricId must be specified when using minSampleCountToEvaluateDatapoint with a multiple-metric MathExpression"

However `sampleCountMetricId` is currently not available in `CustomAlarmThreshold`.

See #466 for original change.

---

_By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
  • Loading branch information
@bamarni
bamarni authored Oct 16, 2024
1 parent 9279cec commit 08e4131
Show file tree
Hide file tree
Showing 2 changed files with 1,002 additions and 0 deletions.
Loading

0 comments on commit 08e4131

Please sign in to comment.