Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 ✨ Improvement of Action Space: BQSKit and Qiskit O3 Optimization #183

Merged
merged 29 commits into from
Feb 5, 2024

Conversation

nquetschlich
Copy link
Collaborator

@nquetschlich nquetschlich commented Jan 4, 2024

To further enhance MQT Predictor by additional supported quantum SDKs, BQSKit has been integrated as an optimization action, synthesis action, and mapping action.

Additionally, the action structure and how it is called has been improved.

Furthermore, the seeding in the used gymnasium environment has been improved.

@nquetschlich nquetschlich added enhancement New feature or request feature New feature or request major Part of a major release labels Jan 4, 2024
@nquetschlich nquetschlich self-assigned this Jan 4, 2024
@nquetschlich nquetschlich marked this pull request as draft January 4, 2024 13:17
@nquetschlich
Copy link
Collaborator Author

In the current state, some test fail because the currently trained models cannot be used when the number of available actions has changed. I will fix this as soon as we prepare the next larger release of MQT Predictor since most likely further changes regarding the actions resp. the overall framework structure may happen in the next weeks.

@nquetschlich nquetschlich changed the title ✨ Prototypical BQSKit Integration ✨ Improvement of Action Space: BQSKit and Qiskit O3 Optimization Jan 5, 2024
@nquetschlich nquetschlich changed the title ✨ Improvement of Action Space: BQSKit and Qiskit O3 Optimization 🎨 ✨ Improvement of Action Space: BQSKit and Qiskit O3 Optimization Jan 5, 2024
@nquetschlich nquetschlich changed the base branch from main to dev February 1, 2024 15:07
@nquetschlich nquetschlich marked this pull request as ready for review February 1, 2024 15:08
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

❗ No coverage uploaded for pull request base (dev@0683e59). Click here to learn what that means.

❗ Current head eea8214 differs from pull request most recent head a0d43b6. Consider uploading reports for the commit a0d43b6 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #183   +/-   ##
=====================================
  Coverage       ?   81.1%           
=====================================
  Files          ?      13           
  Lines          ?    1127           
  Branches       ?       0           
=====================================
  Hits           ?     914           
  Misses         ?     213           
  Partials       ?       0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this LGTM. I am just wondering if it would really be that much more effort to integrate BQSKit a little tighter. Especially given that you spent some time on making TKET work just now.

pyproject.toml Outdated Show resolved Hide resolved
src/mqt/predictor/rl/helper.py Outdated Show resolved Hide resolved
@nquetschlich nquetschlich removed the major Part of a major release label Feb 2, 2024
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for all the changes. This is really looking good already. I just have 2 little typos, a small interface request, and two potential improvements in the tests. Shouldn't take too long, then this is good to go.

pyproject.toml Outdated Show resolved Hide resolved
src/mqt/predictor/rl/PredictorEnv.py Outdated Show resolved Hide resolved
src/mqt/predictor/rl/helper.py Outdated Show resolved Hide resolved
tests/compilation/test_bqskit_integration.py Outdated Show resolved Hide resolved
tests/compilation/test_bqskit_integration.py Outdated Show resolved Hide resolved
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good now. Thanks for the additional changes and tests!

@nquetschlich nquetschlich merged commit 80cdd56 into dev Feb 5, 2024
9 of 11 checks passed
@nquetschlich nquetschlich deleted the bqskit_integration branch February 5, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants