-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π¨ β¨ Improvement of Action Space: BQSKit and Qiskit O3 Optimization #183
Conversation
In the current state, some test fail because the currently trained models cannot be used when the number of available actions has changed. I will fix this as soon as we prepare the next larger release of MQT Predictor since most likely further changes regarding the actions resp. the overall framework structure may happen in the next weeks. |
β¦integration # Conflicts: # src/mqt/predictor/rl/helper.py
β¦ize and map as well
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## dev #183 +/- ##
=====================================
Coverage ? 81.1%
=====================================
Files ? 13
Lines ? 1127
Branches ? 0
=====================================
Hits ? 914
Misses ? 213
Partials ? 0 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this LGTM. I am just wondering if it would really be that much more effort to integrate BQSKit a little tighter. Especially given that you spent some time on making TKET work just now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for all the changes. This is really looking good already. I just have 2 little typos, a small interface request, and two potential improvements in the tests. Shouldn't take too long, then this is good to go.
Co-authored-by: Lukas Burgholzer <[email protected]>
Co-authored-by: Lukas Burgholzer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good now. Thanks for the additional changes and tests!
To further enhance MQT Predictor by additional supported quantum SDKs, BQSKit has been integrated as an optimization action, synthesis action, and mapping action.
Additionally, the action structure and how it is called has been improved.
Furthermore, the seeding in the used
gymnasium
environment has been improved.